Is my Pokemon Soul Silver team good?

These are very good choices, Just make sure you are familiar with the Elite four's styles, As long as you have a fire, water, electric, Psychic, and Ground you should be perfectly fine.